Skip to content

Remove legacy Adopt distributions in v6 - #1185

Merged
brunoborges merged 2 commits into
mainfrom
copilot/remove-adoptopenjdk-openj9
Jul 31, 2026
Merged

Remove legacy Adopt distributions in v6#1185
brunoborges merged 2 commits into
mainfrom
copilot/remove-adoptopenjdk-openj9

Conversation

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description:
AdoptOpenJDK distribution inputs are removed in v6 instead of being treated as aliases. Users must migrate HotSpot workflows to Temurin and OpenJ9 workflows to IBM Semeru.

  • Runtime behavior

    • Removed adopt, adopt-hotspot, and adopt-openj9 distribution support.
    • Added fail-fast errors before cache lookup or vendor requests.
    • Removed .tool-versions adoptopenjdk* silent remapping.
  • Migration guidance

    # v5
    distribution: adopt
    
    # v6+
    distribution: temurin
    # v5
    distribution: adopt-openj9
    
    # v6+
    distribution: semeru
  • Repository updates

    • Removed Adopt implementation, fixtures, and installer tests.
    • Updated package/platform compatibility tables, README, advanced usage docs, and e2e workflows.
    • Regenerated bundled dist/ artifacts.

Related issue:
Handled by linked issue.

Check list:

  • Ran npm run check locally (format, lint, build, test) and all checks pass.
  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copilot AI linked an issue Jul 30, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Remove AdoptOpenJDK and Adopt OpenJ9 distributions in v6 Remove legacy Adopt distributions in v6 Jul 30, 2026
Copilot AI requested a review from brunoborges July 30, 2026 21:35
@brunoborges
brunoborges marked this pull request as ready for review July 30, 2026 21:45
Copilot AI review requested due to automatic review settings July 30, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@brunoborges
brunoborges requested a review from Copilot July 31, 2026 01:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@brunoborges
brunoborges requested a review from Copilot July 31, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (3)

tests/distributors/distribution-factory.test.ts:127

  • This test asserts legacy Adopt distributions return null, but the PR description/issue calls for a fail-fast error with explicit migration guidance. If getJavaDistribution is updated to throw (instead of returning null), this test should assert on the error message and the correct replacement distribution.
  it.each(['adopt', 'adopt-hotspot', 'adopt-openj9'])(
    'does not support legacy Adopt distribution %s',
    async distributionName => {
      expect(
        await getJavaDistribution(distributionName, installerOptions('jdk'))
      ).toBeNull();
    }

src/distributions/distribution-factory.ts:32

  • Legacy Adopt distributions currently fall through to default: return null, which then turns into the generic error No supported distribution was found for input ... in src/setup-java.ts. The PR description/issue requires a hard, fail-fast error that tells users exactly what to migrate to (adopt/adopt-hotspot -> temurin, adopt-openj9 -> semeru).
  switch (distributionName) {
    case JavaDistribution.JdkFile: {
      const {LocalDistribution} = await import('./local/installer.js');
      return new LocalDistribution(normalizedInstallerOptions, jdkFile);
    }

README.md:36

  • The docs now state legacy Adopt distributions were removed, but .tool-versions parsing still silently remaps the asdf vendor prefix adoptopenjdk to temurin (see src/util.ts mapAsdfDistribution: adoptopenjdk: 'temurin'). This contradicts the PR description/issue requirement to remove .tool-versions adoptopenjdk* remapping and fail with a hard error instructing users to pick temurin or semeru explicitly (especially for adoptopenjdk-openj9, which currently collapses to adoptopenjdk and would map to Temurin).
- **Legacy AdoptOpenJDK distributions were removed.** Replace `adopt` or `adopt-hotspot` with `temurin`, and replace `adopt-openj9` with `semeru`.
  • Files reviewed: 15/17 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@brunoborges
brunoborges merged commit 536de9e into main Jul 31, 2026
86 checks passed
@brunoborges
brunoborges deleted the copilot/remove-adoptopenjdk-openj9 branch July 31, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove AdoptOpenJDK and Adopt OpenJ9 distributions in v6

3 participants